Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set user commands as rc.__currsys__ #377

Merged
merged 13 commits into from
Feb 29, 2024

Conversation

hugobuddel
Copy link
Collaborator

Superset of #376

@hugobuddel hugobuddel marked this pull request as draft February 26, 2024 21:07
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.80%. Comparing base (88ee6d6) to head (e2026d4).

Files Patch % Lines
scopesim/effects/electronic.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #377      +/-   ##
==============================================
- Coverage       74.23%   71.80%   -2.44%     
==============================================
  Files              56       56              
  Lines            7864     7867       +3     
==============================================
- Hits             5838     5649     -189     
- Misses           2026     2218     +192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugobuddel hugobuddel marked this pull request as ready for review February 26, 2024 23:51
@hugobuddel hugobuddel marked this pull request as draft February 26, 2024 23:51
@hugobuddel
Copy link
Collaborator Author

I did run all the notebooks in both ScopeSim and the IRDB, and all tests should pass too (as they pass locally), so removing the draft status.

@hugobuddel hugobuddel marked this pull request as ready for review February 27, 2024 00:18
scopesim/effects/data_container.py Outdated Show resolved Hide resolved
scopesim/optics/optical_train.py Show resolved Hide resolved
@teutoburg teutoburg added the refactor Implementation improvement label Feb 28, 2024
@hugobuddel
Copy link
Collaborator Author

So this and AstarVienna/irdb#157 kinda go together. So if we merge this, then the current IRDB packages will not work with the dev_master of ScopeSim.

But I think it is possible "fix" AstarVienna/irdb#157 so it works with both the current version of ScopeSim and the one after this is merged. Then we can create new IRDB packages that work with both versions, and then we can merge this.

@teutoburg
Copy link
Contributor

Then we can create new IRDB packages that work with both versions, and then we can merge this.

New packages are here 👍

@hugobuddel hugobuddel merged commit 8f8963e into dev_master Feb 29, 2024
21 of 23 checks passed
@hugobuddel hugobuddel deleted the hb/nomorecurrsysusercommands branch February 29, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Implementation improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants